Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader Comments: Fix crash when the app is backgrounded #17678

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Reader Comments: Fix crash when the app is backgrounded #17678

merged 1 commit into from
Dec 17, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Dec 16, 2021

Refs p5T066-2T7-p2#comment-10881

This fixes a crash due to the table view cells being configured with an attributed string using HTML source while the app is in the background (due to a layout pass that's triggered by the system to get a snapshot).

To test

  • Navigate to any comment thread.
  • Press Home (or Cmd+Shift+H on the Simulator).
  • Tap on the WordPress app again.
  • 🔍 Verify that the app does not crash.

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested to ensure the crash isn't occurring.

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added this to the 18.9 ❄️ milestone Dec 16, 2021
@dvdchr dvdchr requested a review from ScoutHarris December 16, 2021 09:02
@dvdchr dvdchr self-assigned this Dec 16, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

ScoutHarris
ScoutHarris approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

:shipit:

@dvdchr dvdchr merged commit 11c86b7 into release/18.9 Dec 17, 2021
@dvdchr dvdchr deleted the fix/comment-thread-restoration-crash branch December 17, 2021 07:00
@mokagio mokagio mentioned this pull request Dec 21, 2021
Merged
@dvdchr dvdchr mentioned this pull request Mar 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScoutHarris ScoutHarris ScoutHarris approved these changes

Assignees

@dvdchr dvdchr

Labels
Comments Reader [Type] Crash
Projects
None yet
Milestone
18.9
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdchr @ScoutHarris